Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssr): skip optional peer dep resolve (v3) (#10593) #10931

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Nov 15, 2022

cherry pick of #10593 as it's a regression introduce in v3.1

@patak-dev
Copy link
Member

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

vite-ecosystem-ci bot commented Nov 15, 2022

📝 Ran ecosystem CI: Open

suite result
astro ✅ success
histoire ✅ success
iles ✅ success
ladle ✅ success
laravel ✅ success
marko ✅ success
nuxt-framework ✅ success
rakkas ✅ success
svelte ❌ failure
vite-plugin-ssr ✅ success
vite-setup-catalogue ✅ success
vitepress ✅ success
vitest ✅ success
windicss ✅ success

@bluwy
Copy link
Member Author

bluwy commented Nov 15, 2022

Looks like svelte got split out as vite-plugin-svelte and sveltekit (which is great 🎉 ). I don't think we have tests there that covers peer deps so it should be good too.

@patak-dev patak-dev merged commit 7f59dcf into v3 Nov 15, 2022
@patak-dev patak-dev deleted the cherry-ssr-optional-deps branch November 15, 2022 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants